Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Don't apply changes while inserting aggregate #64

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fix(node): Don't apply changes while inserting aggregate #64

merged 1 commit into from
Jan 4, 2024

Conversation

pjechris
Copy link
Owner

@pjechris pjechris commented Jan 4, 2024

⚽️ Description

Fix a crash where a node might try to update its children while being inserted.

This could happen if the same element is inserted multiple times in a single transaction (for instance, with an array).

Despite facing the bug on my project (while using aliases) I was not able to make a non regression test.

🔨 Implementation details

Reintroduce applyChildrenChanges to skip any change while inserting/updating the aggregate

@pjechris pjechris added the bug Something isn't working label Jan 4, 2024
@pjechris pjechris merged commit d0f9354 into main Jan 4, 2024
2 checks passed
@pjechris pjechris deleted the fix/entityNode-observe branch January 4, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pjechris